Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 88cb101.
elan-tbx
added
trivial
elan-tbx
requested review from
ryanmparrish,
Blainegunn,
overmyheadandbody,
JasonHowellSlavin,
Dli3 and
mokimo
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2777 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 173 173
Lines 45853 45842 -11
=======================================
- Hits 43969 43960 -9
+ Misses 1884 1882 -2 ☔ View full report in Codecov by Sentry. |
elan-tbx
added a commit
that referenced
this pull request
Aug 22, 2024
elan-tbx
added a commit
that referenced
this pull request
Aug 23, 2024
mokimo
pushed a commit
that referenced
this pull request
Aug 29, 2024
* add multiviewport content control * minor style tweaks, leaving text.js alone for now * Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (#2777) Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (#2767)" This reverts commit 88cb101. * per-viewport dom replacing, and popup behavior support * account for flexible box shadow * update mock * improvements based on PR feedback * handle resize multi-viewport edge case * accounting for ribbon edge cases * sticky top pill edge case, default bg * handle body-only copy area
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
* update button decorator to handle custom classes * add dash character to regex * add coverage * add safeguard for href-less buttons * account for modals * Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (#2777) Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (#2767)" This reverts commit 88cb101. * add modal coverage * Revert "Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (#2777)" This reverts commit b1a3948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2767
Unfortunately, yet another regression error was discovered in regards to the recently deprecated
notificationvariant of this block.I'll be putting in extra time to go over every possible use-case of the notification aside with a fine-toothed comb so this doesn't happen again, but in the meantime this PR should get reverted from stage.
Test URLs:
Actual page where issue is visible
Doc URLs to make the PSI bot happy