Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157445 Additional Lana LCP data #2805

Merged
merged 1 commit into from
Sep 3, 2024
Merged

MWPW-157445 Additional Lana LCP data #2805

merged 1 commit into from
Sep 3, 2024

Conversation

chrischrischris
Copy link
Contributor

Add isFrag and isMep attributes to lana LCP logging.

Resolves: MWPW-157445

Test URLs:

@chrischrischris chrischrischris requested a review from a team as a code owner August 29, 2024 19:34
Copy link
Contributor

aem-code-sync bot commented Aug 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 29, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (d90dcc0) to head (cc6c689).
Report is 23 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2805      +/-   ##
==========================================
- Coverage   95.90%   95.89%   -0.02%     
==========================================
  Files         173      173              
  Lines       45842    45910      +68     
==========================================
+ Hits        43967    44026      +59     
- Misses       1875     1884       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@SilviuLCF SilviuLCF self-assigned this Aug 30, 2024
@SilviuLCF SilviuLCF self-requested a review August 30, 2024 07:45
mokimo

This comment was marked as resolved.

Comment on lines +89 to +93
if (closestFrag) {
lanaData.isMep = isFragmentFromMep(closestFrag.dataset.path, mep) ? 'true' : 'false';
} else {
lanaData.isMep = 'false';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: couldn't we also do:

Suggested change
if (closestFrag) {
lanaData.isMep = isFragmentFromMep(closestFrag.dataset.path, mep) ? 'true' : 'false';
} else {
lanaData.isMep = 'false';
}
lanaData.isMep = closestFrag && isFragmentFromMep(closestFrag.dataset.path, mep)
? 'true' : 'false';

Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for STAGE
Testing details
https://jira.corp.adobe.com/browse/MWPW-157445

@milo-pr-merge milo-pr-merge bot merged commit 7216452 into stage Sep 3, 2024
16 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mwpw-157445 branch September 3, 2024 08:39
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants