-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157445 Additional Lana LCP data #2805
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2805 +/- ##
==========================================
- Coverage 95.90% 95.89% -0.02%
==========================================
Files 173 173
Lines 45842 45910 +68
==========================================
+ Hits 43967 44026 +59
- Misses 1875 1884 +9 ☔ View full report in Codecov by Sentry. |
Reminder to set the |
if (closestFrag) { | ||
lanaData.isMep = isFragmentFromMep(closestFrag.dataset.path, mep) ? 'true' : 'false'; | ||
} else { | ||
lanaData.isMep = 'false'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: couldn't we also do:
if (closestFrag) { | |
lanaData.isMep = isFragmentFromMep(closestFrag.dataset.path, mep) ? 'true' : 'false'; | |
} else { | |
lanaData.isMep = 'false'; | |
} | |
lanaData.isMep = closestFrag && isFragmentFromMep(closestFrag.dataset.path, mep) | |
? 'true' : 'false'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for STAGE
Testing details
https://jira.corp.adobe.com/browse/MWPW-157445
Add
isFrag
andisMep
attributes to lana LCP logging.Resolves: MWPW-157445
Test URLs: