MWPW-157292: CC and DC: Phone number links wrong #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2841 +/- ##
==========================================
- Coverage 95.89% 95.88% -0.01%
==========================================
Files 173 173
Lines 46316 46319 +3
==========================================
- Hits 44415 44414 -1
- Misses 1901 1905 +4 ☔ View full report in Codecov by Sentry. |
chrischrischris
requested changes
Sep 5, 2024
added 2 commits
September 5, 2024 21:13
chrischrischris
approved these changes
Sep 5, 2024
mokimo
approved these changes
Sep 5, 2024
elan-tbx
pushed a commit
that referenced
this pull request
Sep 9, 2024
* MWPW-157292: CC and DC: Phone number links wrong * Unit tests * Unit tests --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phone number on the following pages is appearing correctly in the text but showing random characters in the link. Previously, using the placeholder for both the display text and link text displayed the number correctly.
Resolves: [MWPW-157292]
Test URLs:
Before: https://main--milo--adobecom.hlx.live/drafts/suhjain/performance/marquee-light
After:https://placeholderOriginNew--milo--suhjainadobe.hlx.live/drafts/suhjain/performance/marquee-light