Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-158021] Move Nala tests to Milo Repo #2847

Merged
merged 53 commits into from
Sep 16, 2024
Merged

[MWPW-158021] Move Nala tests to Milo Repo #2847

merged 53 commits into from
Sep 16, 2024

Conversation

skumar09
Copy link
Contributor

@skumar09 skumar09 commented Sep 8, 2024 •
edited
Loading

  1. Move following Nala tests to Milo Repo

Blocks

  • Accordion
  • Aside
  • Action-item
  • Carousel
  • Card
  • Chart
  • Columns
  • Figure
  • HowTo
  • Icon
  • IFrame
  • Marketo
  • Marquee
  • Media
  • Merchcard
  • Modal
  • Quote
  • Review
  • Table
  • Tabs
  • Text
  • Video
  • Zpattern

Features

  • Georouting
  • Commerce
  • Feds
  • OST
  • Promotions
  1. Set Default GitHub Action for running Nala Tests on PRs

Resolves: MWPW-158021

Test URLs:

milo-pr-merge bot added 30 commits June 3, 2024 15:20
@milo-pr-merge
[Release] Stage to Main (adobecom#2359)
be90c7d
@milo-pr-merge
[Release] Stage to Main (adobecom#2409)
d9af238
@milo-pr-merge
[Release] Stage to Main (adobecom#2414)
b07f1a5
@milo-pr-merge
[Release] Stage to Main (adobecom#2423)
e5bff30
@milo-pr-merge
[Release] Stage to Main (adobecom#2432)
81d0085
@milo-pr-merge
[Release] Stage to Main (adobecom#2447)
e8300af
@milo-pr-merge
[Release] Stage to Main (adobecom#2462)
2350bd0
@milo-pr-merge
[Release] Stage to Main (adobecom#2470)
931fa67
@milo-pr-merge
[Release] Stage to Main (adobecom#2472)
ead382f
@milo-pr-merge
[Release] Stage to Main (adobecom#2479)
ddbdf7a
@milo-pr-merge
[Release] Stage to Main (adobecom#2482)
02bf1a6
@milo-pr-merge
[Release] Stage to Main (adobecom#2489)
f6fc4bf
@milo-pr-merge
[Release] Stage to Main (adobecom#2495)
47aaef0
@milo-pr-merge
[Release] Stage to Main (adobecom#2503)
03578fb
@milo-pr-merge
[Release] Stage to Main (adobecom#2515)
32f61f0
@milo-pr-merge
[Release] Stage to Main (adobecom#2520)
2217784
@milo-pr-merge
[Release] Stage to Main (adobecom#2528)
862fdab
@milo-pr-merge
[Release] Stage to Main (adobecom#2540)
88577c7
@milo-pr-merge
[Release] Stage to Main (adobecom#2556)
830f7e1
@milo-pr-merge
[Release] Stage to Main (adobecom#2568)
bc210e6
@milo-pr-merge
[Release] Stage to Main (adobecom#2571)
04e211c
@milo-pr-merge
[Release] Stage to Main (adobecom#2580)
4e99424
@milo-pr-merge
[Release] Stage to Main (adobecom#2592)
61f8c81
@milo-pr-merge
[Release] Stage to Main (adobecom#2602)
3365940
@milo-pr-merge
[Release] Stage to Main (adobecom#2609)
e89908c
@milo-pr-merge
[Release] Stage to Main (adobecom#2617)
f551e5b
@milo-pr-merge
[Release] Stage to Main (adobecom#2629)
5028ef5
@milo-pr-merge
[Release] Stage to Main (adobecom#2641)
0073337
@milo-pr-merge
[Release] Stage to Main (adobecom#2648)
c3371ce
@milo-pr-merge
[Release] Stage to Main (adobecom#2666)
8f6bc8f
mokimo
mokimo approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Lovely to see more nala tests moving in

@afmicka
Copy link
Contributor

afmicka commented Sep 9, 2024 •
edited
Loading

@skumar09 OST tests are not being executed under commerce nor ost tag. It does not find the tests at all. Do you know why? The other commerce tests are executing OK with the tags.

npm run nala stage @ost

Screenshot 2024-09-09 at 16 07 31

EDIT: I found out it is because of nopr tag. Any way to run these tests locally despite the nopr tag?

@JackySun9 JackySun9 added run-nala Run Nala Test Automation against PR Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs Ready for Stage and removed Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Sep 9, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 9, 2024

Error merging 2847: [MWPW-158021] Move Nala tests to Milo Repo Resource not accessible by integration

@JackySun9
Copy link
Contributor

@skumar09 please fix this

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 11, 2024

Error merging 2847: [MWPW-158021] Move Nala tests to Milo Repo Resource not accessible by integration

TsayAdobe
TsayAdobe requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@TsayAdobe TsayAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the nala directory to.hlxignore

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 12, 2024

Error merging 2847: [MWPW-158021] Move Nala tests to Milo Repo Resource not accessible by integration

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 16, 2024

Error merging 2847: [MWPW-158021] Move Nala tests to Milo Repo Resource not accessible by integration

@mokimo mokimo merged commit d7ae16e into adobecom:stage Sep 16, 2024
14 checks passed
@mokimo mokimo mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jk jk jk left review comments

@robert-bogos robert-bogos robert-bogos approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@TsayAdobe TsayAdobe TsayAdobe approved these changes

@mokimo mokimo mokimo approved these changes

@Dli3 Dli3 Dli3 approved these changes

@afmicka afmicka afmicka approved these changes

@amauch-adobe amauch-adobe Awaiting requested review from amauch-adobe

@narcis-radu narcis-radu Awaiting requested review from narcis-radu

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

@sigadamvenkata sigadamvenkata Awaiting requested review from sigadamvenkata

Assignees
No one assigned
Labels
Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@skumar09 @afmicka @JackySun9 @jk @Dli3 @mokimo @TsayAdobe @robert-bogos