-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157682 Check CLS for photoshop page #2860
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2860 +/- ##
==========================================
+ Coverage 95.87% 96.10% +0.23%
==========================================
Files 173 215 +42
Lines 46333 53958 +7625
==========================================
+ Hits 44421 51856 +7435
- Misses 1912 2102 +190 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
As a side note, I'm wondering if it would be helpful if we documented which blocks should async/await
their stylesheet imports (like iconography.css) and which blocks shouldn't, outside of common sense. For example, marquees will likely be in the LCP understandably, so they should await
the stylesheet to avoid a CLS, but I wonder if it's at all possible to get stats on other blocks that often appear in LCP so we can further optimize loading.
The text area in the hero-marquee is coming in CLS with iconography.css being a dependency
Resolves: MWPW-157682
Test URLs: