Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157682 Check CLS for photoshop page #2860

Merged
merged 9 commits into from
Sep 16, 2024

Conversation

suhjainadobe
Copy link
Contributor

@suhjainadobe suhjainadobe commented Sep 10, 2024

The text area in the hero-marquee is coming in CLS with iconography.css being a dependency
image

Resolves: MWPW-157682

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 10, 2024

Page Scores Audits Google
M /drafts/suhjain/hero-marquee PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/suhjain/hero-marquee PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (510f7a6) to head (bc496b3).
Report is 24 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2860      +/-   ##
==========================================
+ Coverage   95.87%   96.10%   +0.23%     
==========================================
  Files         173      215      +42     
  Lines       46333    53958    +7625     
==========================================
+ Hits        44421    51856    +7435     
- Misses       1912     2102     +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@mokimo mokimo requested a review from elan-tbx September 12, 2024 11:32
@spadmasa
Copy link

spadmasa commented Sep 13, 2024

Validations done on below url :
https://heromarquee--milo--suhjainadobe.hlx.live/drafts/suhjain/hero-marquee
https://pagespeed.web.dev/analysis/https-heromarquee--milo--suhjainadobe-hlx-live-drafts-suhjain-hero-marquee/rbbqfwb59f?form_factor=mobile
{DEFCCAB2-329F-489E-BDF3-E463F85AC593}
https://pagespeed.web.dev/analysis/https-heromarquee--milo--suhjainadobe-hlx-live-drafts-suhjain-hero-marquee/rbbqfwb59f?form_factor=desktop
{E062551E-F72D-4E25-B330-8123DFDEEDFA}

Validated on below url :
https://main--cc--adobecom.hlx.live/drafts/souj/performance/photoshop1?milolibs=heromarquee--milo--suhjainadobe
Before url :
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-photoshop1/iu3o7nw4l9?form_factor=mobile
after url
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-photoshop1/rxkpfpj9gy?form_factor=mobile

{68392AD5-1ABF-4040-9529-167ADD593B56}

in illustrator :
https://main--cc--adobecom.hlx.live/drafts/souj/performance/illustrator1?milolibs=heromarquee--milo--suhjainadobe

before url
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-illustrator1/fj8tfezlth?form_factor=desktop

after url
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-illustrator1/shmmf8iosf?form_factor=desktop

Validated on below url :
https://main--cc--adobecom.hlx.live/drafts/souj/performance/photoshop1?milolibs=heromarquee--milo--suhjainadobe
Before url :
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-photoshop1/iu3o7nw4l9?form_factor=mobile
after url
https://pagespeed.web.dev/analysis/https-main--cc--adobecom-hlx-live-drafts-souj-performance-photoshop1/rxkpfpj9gy?form_factor=mobile

@suhjainadobe , @sigadamvenkata , @salonijain3

@spadmasa spadmasa self-assigned this Sep 13, 2024
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 13, 2024
Copy link
Contributor

@elan-tbx elan-tbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

As a side note, I'm wondering if it would be helpful if we documented which blocks should async/await their stylesheet imports (like iconography.css) and which blocks shouldn't, outside of common sense. For example, marquees will likely be in the LCP understandably, so they should await the stylesheet to avoid a CLS, but I wonder if it's at all possible to get stats on other blocks that often appear in LCP so we can further optimize loading.

@milo-pr-merge milo-pr-merge bot merged commit 2ee8d3b into adobecom:stage Sep 16, 2024
21 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants