-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157888 - Hero marquee w/ no-min-height
and no l/r padding when using a full-width
variant
#2861
Conversation
Adding GWP drafts here - They were negatively impacting the PSI check GWP drafts:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2861 +/- ##
==========================================
+ Coverage 95.90% 96.10% +0.19%
==========================================
Files 173 215 +42
Lines 45842 53956 +8114
==========================================
+ Hits 43967 51856 +7889
- Misses 1875 2100 +225 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified by @NadiiaSokolova and ready to STAGE from QA perspective
Testing details can be found here
https://jira.corp.adobe.com/browse/MWPW-157888
Skipped 2861: "MWPW-157888 - Hero marquee w/ |
As and author in a milo project using a [hero-marquee]
full-width
and not have the extra left/right padding seen in this scenario.Example screenshot - Notice the block height is huge, the l/r padding is causing the block to go outside its bounds.
Fixed
no-min-height
variant to the hero-marquee.has-bg
class being added.Resolves: MWPW-157888
Test URLs: