Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant #2861

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

ryanmparrish
Copy link
Contributor

@ryanmparrish ryanmparrish commented Sep 10, 2024

As and author in a milo project using a [hero-marquee]

  1. I want to use this block with out a minimal height so the block has a natural height based on content.
  2. I want to use this block in an ups grid w/ the variant full-width and not have the extra left/right padding seen in this scenario.

Example screenshot - Notice the block height is huge, the l/r padding is causing the block to go outside its bounds.
Screen Shot 2024-09-10 at 12 13 11 PM


Fixed

  1. Add a no-min-height variant to the hero-marquee.
  2. Address padding issue on hero-block. Erroneously comes from the has-bg class being added.

Resolves: MWPW-157888

Test URLs:

@ryanmparrish ryanmparrish added the needs-verification PR requires E2E testing by a reviewer label Sep 10, 2024
@ryanmparrish ryanmparrish requested a review from a team September 10, 2024 18:15
Copy link
Contributor

aem-code-sync bot commented Sep 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@ryanmparrish
Copy link
Contributor Author

Adding GWP drafts here - They were negatively impacting the PSI check

GWP drafts:

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (d90dcc0) to head (28ae72a).
Report is 70 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2861      +/-   ##
==========================================
+ Coverage   95.90%   96.10%   +0.19%     
==========================================
  Files         173      215      +42     
  Lines       45842    53956    +8114     
==========================================
+ Hits        43967    51856    +7889     
- Misses       1875     2100     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviuLCF SilviuLCF self-requested a review September 16, 2024 08:11
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by @NadiiaSokolova and ready to STAGE from QA perspective

Testing details can be found here
https://jira.corp.adobe.com/browse/MWPW-157888

@SilviuLCF SilviuLCF added Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Sep 16, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 16, 2024

Skipped 2861: "MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant" due to file "libs/blocks/hero-marquee/hero-marquee.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit eb788ce into stage Sep 17, 2024
22 checks passed
@milo-pr-merge milo-pr-merge bot deleted the rparrish/hero-no-min branch September 17, 2024 09:15
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants