Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158353: Updates configurator label to Carousel Animation Style #2888

Merged
merged 48 commits into from
Sep 17, 2024

Conversation

cmiqueo
Copy link
Contributor

@cmiqueo cmiqueo commented Sep 16, 2024

This PR updates configurator label for clarity
from
Animation Style
to
Carousel Animation Style

image

Resolves: MWPW-158353

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (6fa9558) to head (7134495).
Report is 11 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2888      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.02%     
==========================================
  Files         238      237       -1     
  Lines       54310    54242      -68     
==========================================
- Hits        52276    52204      -72     
- Misses       2034     2038       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmiqueo cmiqueo added trivial PR doesn't require E2E testing by a reviewer caas-configurator CaaS Configurator Ready for Stage labels Sep 16, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 16, 2024

Skipped merging 2888: MWPW-158353: Updates configurator label to Carousel Animation Style due to failing checks

@JackySun9 JackySun9 added run-nala-on-caas and removed trivial PR doesn't require E2E testing by a reviewer caas-configurator CaaS Configurator Ready for Stage labels Sep 16, 2024
@cmiqueo cmiqueo added trivial PR doesn't require E2E testing by a reviewer caas-configurator CaaS Configurator zero-impact labels Sep 16, 2024
Copy link
Contributor

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

@cmiqueo cmiqueo removed caas-configurator CaaS Configurator trivial PR doesn't require E2E testing by a reviewer labels Sep 16, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024

Page Scores Audits Google
📱 /drafts/cmiqueo/foo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/cmiqueo/foo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge milo-pr-merge bot merged commit 9323f28 into stage Sep 17, 2024
55 of 61 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-158353 branch September 17, 2024 20:10
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants