-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-158756] Enhance stage links conversion for cross-domain localization #2913
[MWPW-158756] Enhance stage links conversion for cross-domain localization #2913
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2913 +/- ##
=======================================
Coverage 96.23% 96.24%
=======================================
Files 236 236
Lines 54253 54254 +1
=======================================
+ Hits 52213 52217 +4
+ Misses 2040 2037 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should write a unit test for this case as well
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for STAGE
Testing details https://jira.corp.adobe.com/browse/MWPW-158756
Skipped merging 2913: [MWPW-158756] Enhance stage links conversion for cross-domain localization due to failing checks |
Description
This PR enhances the stage links conversion feature to handle cross-domain localization.
Related Issue
Resolves: MWPW-158756
Testing instructions
open the after test URL
using the developer tools, overwrite scrips.js to :
'business.adobe.com'
in theprodDomains
array;in the
stageDomainsMap
config.Test URLs
Milo: