Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto label nala PRs as zero impact #2936

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mokimo
Copy link
Contributor

@mokimo mokimo commented Sep 23, 2024

Description

Nala PRs do not impact production in any way, hence can always be included in a batch at any point.

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 23, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (c5e352f) to head (2434e7a).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2936      +/-   ##
==========================================
- Coverage   98.21%   96.27%   -1.94%     
==========================================
  Files          64      238     +174     
  Lines        7848    54515   +46667     
==========================================
+ Hits         7708    52485   +44777     
- Misses        140     2030    +1890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mokimo
Copy link
Contributor Author

mokimo commented Sep 23, 2024

I'll manually merge this given the approvals and this being zero impact.

@mokimo mokimo merged commit 3118631 into adobecom:stage Sep 23, 2024
12 of 14 checks passed
@mokimo mokimo mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants