Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant in masonry(repost)" #3002

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Oct 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 3, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (6cdc02a) to head (6dcb36f).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3002      +/-   ##
==========================================
- Coverage   96.37%   96.35%   -0.02%     
==========================================
  Files         243      243              
  Lines       55122    55119       -3     
==========================================
- Hits        53122    53111      -11     
- Misses       2000     2008       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the details in the story, it would seem that this PR isn't blocking a batch release, nor is it relevant for MAX, so its video CLS counterpart should probably get priority

@overmyheadandbody overmyheadandbody merged commit 9b05053 into stage Oct 3, 2024
14 checks passed
@overmyheadandbody overmyheadandbody deleted the revert-2923-rparrish/hero-bg-fix-2 branch October 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants