MWPW-158455: Promobar overlays with localnav elements in devices (#2991) #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…becom#2991) * Revert "MWPW-156749: Fix video CLS " (adobecom#2899) (adobecom#2900) Revert "MWPW-156749: Fix video CLS (adobecom#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <>
overmyheadandbody
requested review from
narcis-radu,
salonijain3 and
robert-bogos
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3033 +/- ##
==========================================
- Coverage 96.32% 96.32% -0.01%
==========================================
Files 243 243
Lines 55143 55143
==========================================
- Hits 53117 53115 -2
- Misses 2026 2028 +2 ☔ View full report in Codecov by Sentry. |
salonijain3
approved these changes
Oct 11, 2024
robert-bogos
approved these changes
Oct 11, 2024
narcis-radu
approved these changes
Oct 11, 2024
spadmasa
added
Ready for Main
|
Verified in stage , details are added in https://jira.corp.adobe.com/browse/MWPW-159426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be fast-tracked to
mainas it contains essential updates for MAX.Initial stage PR: #2991
Included in the batch for main: #3004
Resolves: MWPW-158455 & MWPW-159426
Test URLs: