Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(MWPW-146367):Added accessibility player controls (NON MPC) #3053

Merged
merged 42 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
ae0fa67
updated feature with accessibility code
sharath-kannan Oct 15, 2024
b9ff89a
video accessiblity added for carousels
sharath-kannan Oct 16, 2024
d0b659f
added opt-out functionality
sharath-kannan Oct 16, 2024
66b50a8
fixed linting errors
sharath-kannan Oct 17, 2024
853df47
fixed unit test cases
sharath-kannan Oct 17, 2024
48517ac
fixed adobe tv issue
sharath-kannan Oct 18, 2024
e39ce89
hover and focus added
sharath-kannan Oct 18, 2024
1bb2332
controls positioned for rtl
sharath-kannan Oct 24, 2024
417e3f6
Merge branch 'adobecom:stage' into mwpw-146367
sharath-kannan Oct 24, 2024
1b7a379
hide-controls hash params added
sharath-kannan Oct 24, 2024
ae4d004
how to block controls position bug fix
sharath-kannan Oct 24, 2024
34db839
dark mode|bug fixes
sharath-kannan Oct 29, 2024
b233253
code enhancement
sharath-kannan Oct 29, 2024
0ac85c9
pause-play bug mouse click bug fix
sharath-kannan Oct 30, 2024
45f7091
marquee dark mode|positioning fix
sharath-kannan Oct 30, 2024
287ecb1
code enhancement
sharath-kannan Nov 4, 2024
51e2de3
handled marquee backward compatiblity
sharath-kannan Nov 4, 2024
90b734f
Added placeholder for labels|indexed video aria-labels
sharath-kannan Nov 5, 2024
a54bbc3
aria-label added for hover play videos
sharath-kannan Nov 5, 2024
2707f51
async awaited decorateVideo in video.js and other linting errors
sharath-kannan Nov 6, 2024
4444c4c
video indexes added
sharath-kannan Nov 7, 2024
f268e20
random video index and unit test cases updated
sharath-kannan Nov 9, 2024
e5f53cd
daa-ll is synced along with aria-label
sharath-kannan Nov 11, 2024
43a13b5
code enhancement
sharath-kannan Nov 11, 2024
afa16ea
Merge branch 'adobecom:stage' into mwpw-146367
sharath-kannan Nov 11, 2024
cdd5eac
nala test fix|code coverege
sharath-kannan Nov 12, 2024
1bc65be
nala test bug fix
sharath-kannan Nov 12, 2024
f0de063
nala test fix
sharath-kannan Nov 12, 2024
7e47a2c
right-left positioning is done for screens > 600px and a img fix
sharath-kannan Nov 12, 2024
6522411
getFedsconfig moved to feds file|url fetched from fedRoot function
sharath-kannan Nov 13, 2024
185bf61
linting fix
sharath-kannan Nov 13, 2024
3608371
Merge branch 'adobecom:stage' into mwpw-146367
sharath-kannan Nov 14, 2024
f9dac71
icons adapted to the figma
sharath-kannan Nov 14, 2024
db007bd
carousel and how-to fix with other minor fixes
sharath-kannan Nov 15, 2024
0248ad9
playpause wrapper adjusted for window
sharath-kannan Nov 15, 2024
0d964fa
icon offset bug fix
sharath-kannan Nov 18, 2024
1f6f617
Merge branch 'adobecom:stage' into mwpw-146367
sharath-kannan Nov 20, 2024
958f9aa
indentation of string literal
sharath-kannan Nov 27, 2024
518b4a0
figma match
sharath-kannan Dec 2, 2024
80a6f69
figma focus match
sharath-kannan Dec 2, 2024
224a542
Merge branch 'adobecom:stage' into mwpw-146367
sharath-kannan Dec 2, 2024
c32e97f
Merge branch 'stage' into mwpw-146367
sharath-kannan Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nala test fix
  • Loading branch information
sharath-kannan committed Nov 12, 2024
commit f0de063b2755ee665f5ffa123b042c7c2a48bb9c
2 changes: 1 addition & 1 deletion nala/blocks/marquee/marquee.test.js
Original file line number Diff line number Diff line change
@@ -582,7 +582,7 @@ test.describe('Milo Marquee Block test suite', () => {
await test.step('step-3: Verify analytic attributes', async () => {
await expect(await marquee.marqueeLargeLight).toHaveAttribute('daa-lh', await webUtil.getBlockDaalh('marquee', 1));
await expect(await marquee.blueButtonXL).toHaveAttribute('daa-ll', await webUtil.getLinkDaall(data.blueButtonText, 2, data.h2Text));
await expect(await marquee.actionLink2).toHaveAttribute('daa-ll', await webUtil.getLinkDaall(data.linkText, 2, data.h2Text));
await expect(await marquee.actionLink3).toHaveAttribute('daa-ll', await webUtil.getLinkDaall(data.linkText, 3, data.h2Text));
});
});

Loading