Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161293 [MEP] add some selectors for the text blocks #3077

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Oct 22, 2024

  • Adds this.textBlocks and this.textIntroBlocks to enable a count()
  • Adds headlineAlt and introHeadlineAlt for an alternate way to obtain the headline in a text block
  • Adds a .nth to this.textIntro
    this.textIntro = this.page.locator('.text.intro').nth(nth);

Resolves: MWPW-161293

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (ec48f3c) to head (3d49e80).
Report is 63 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3077      +/-   ##
==========================================
+ Coverage   96.34%   96.43%   +0.09%     
==========================================
  Files         243      245       +2     
  Lines       55284    55727     +443     
==========================================
+ Hits        53261    53743     +482     
+ Misses       2023     1984      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgoodric vgoodric requested a review from skumar09 October 22, 2024 20:00
@vgoodric vgoodric changed the title add some selectors for the text and intro text blocks MWPW-160881 add some selectors for the text and intro text blocks Oct 22, 2024
Copy link
Contributor

aem-code-sync bot commented Oct 22, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jpratt2 jpratt2 changed the title MWPW-160881 add some selectors for the text and intro text blocks MWPW-160881 add some selectors for the text blocks Oct 29, 2024
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@jpratt2 jpratt2 changed the title MWPW-160881 add some selectors for the text blocks MWPW-161293 [MEP] add some selectors for the text blocks Oct 30, 2024
Copy link
Contributor

@skumar09 skumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...

@jpratt2 jpratt2 added verified PR has been E2E tested by a reviewer Ready for Stage labels Oct 31, 2024
@milo-pr-merge milo-pr-merge bot merged commit d809cd5 into stage Oct 31, 2024
22 checks passed
@milo-pr-merge milo-pr-merge bot deleted the new_textblock_selectors branch October 31, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants