MWPW-160058: Fixes tag matching case logic

[cmiqueo]

The problem:

Right now, the milo send-utils.js script compares the tags from adobe.com with the tags in the page.

But before comparing the tags it "lower-cases" ONLY the tags from adobe.com and not the ones from the page:

Proposed solution:

Lower case both set of tag values before comparing them.

Resolves: MWPW-160058

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/?martech=off
• After: https://MWPW-160058--milo--adobecom.hlx.page/?martech=off

@mokimo
This is a (fairly large and complex) utilities file that was created long time ago and it does not have any test coverage. We are planing on creating a story to add a full code coverage to all the functionalities in the file, but we should not hold up any small incremental improvements.

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 8f6bc8f ❌ (latest)
• c3371ce ❌
• 0073337 ❌
• 5028ef5 ❌
• f551e5b ❌
• e89908c ❌
• 3365940 ❌
• 61f8c81 ❌
• 4e99424 ❌
• 04e211c ❌
• bc210e6 ❌
• 830f7e1 ❌
• 88577c7 ❌
• 862fdab ❌
• 2217784 ❌
• 32f61f0 ❌
• 03578fb ❌
• 47aaef0 ❌
• f6fc4bf ❌
• 02bf1a6 ❌
• ddbdf7a ❌
• ead382f ❌
• 931fa67 ❌
• 2350bd0 ❌
• e8300af ❌
• 81d0085 ❌
• e5bff30 ❌
• b07f1a5 ❌
• d9af238 ❌
• be90c7d ❌

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (c61c4d6) to head (c06c081).
Report is 36 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3098      +/-   ##
==========================================
- Coverage   96.43%   96.34%   -0.09%     
==========================================
  Files         245      245              
  Lines       55746    56317     +571     
==========================================
+ Hits        53757    54258     +501     
- Misses       1989     2059      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[cmiqueo]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@mokimo
This is a (fairly large and complex) utilities file that was created long time ago and it does not have any test coverage. We are planing on creating a story to add a full code coverage to all the functionalities in the file, but we should not hold up any small incremental improvements.

[milo-pr-merge]

Skipped merging 3098: MWPW-160058: Fixes tag matching case logic due to failing checks

[mokimo]

You could ignore the coverage for thsi line https://github.com/bcoe/c8/blob/main/README.md
Other than that, someone (likely me) would have to manually merge this, but I have to hit the time where a batch isn't tested so that's more un-predictable and takes a bit longer!

[milo-pr-merge]

Skipped merging 3098: MWPW-160058: Fixes tag matching case logic due to failing checks