Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159381: Removes 'body' overrides from caas.css #3110

Merged
merged 67 commits into from
Nov 4, 2024
Merged

Conversation

cmiqueo
Copy link
Contributor

@cmiqueo cmiqueo commented Oct 29, 2024

Removes Removes 'body' overrides from CaaS CSS file '/deps/caas.css' used by the MIlo Card block.

Resolves: MWPW-159381

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 29, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (c61c4d6) to head (dd51bb3).
Report is 36 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3110      +/-   ##
==========================================
- Coverage   96.43%   96.33%   -0.10%     
==========================================
  Files         245      247       +2     
  Lines       55746    56235     +489     
==========================================
+ Hits        53757    54176     +419     
- Misses       1989     2059      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmiqueo cmiqueo added CaaS CaaS related code trivial PR doesn't require E2E testing by a reviewer Ready for Stage labels Oct 29, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 1, 2024

Skipped merging 3110: MWPW-159381: Removes 'body' overrides from caas.css due to insufficient approvals. Required: 2 approvals

@milo-pr-merge milo-pr-merge bot merged commit 1e16205 into stage Nov 4, 2024
25 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-159381 branch November 4, 2024 17:51
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 4, 2024
mokimo added a commit that referenced this pull request Nov 5, 2024
@mokimo
Copy link
Contributor

mokimo commented Nov 5, 2024

hey @cmiqueo this leads to some issues and will need to be pulled out: #3139

mokimo added a commit that referenced this pull request Nov 5, 2024
Revert "MWPW-159381: Removes 'body' overrides from caas.css (#3110)"

This reverts commit 1e16205.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CaaS CaaS related code Ready for Stage trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants