MWPW-161174 fixed library query param #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3128 +/- ##
==========================================
- Coverage 96.35% 96.34% -0.01%
==========================================
Files 245 245
Lines 56316 56316
==========================================
- Hits 54261 54256 -5
- Misses 2055 2060 +5 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
mokimo
approved these changes
Nov 4, 2024
|
|
Reminder to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, our
.hlx.livepage is protected with an access.live.allow rule in .config. and because of this we are not able to add our blocks to the library in sidekick. You can find more information here: https://github.com/orgs/adobecom/discussions/3121We found that there is a possibility to fetch library blocks data from custom url by adding
libraryquery param to library URL inconfig.json, but we found the bug inlibrary-config.jsand because of this bug, custom library URL will be fetched two times, and milo library data will be skipped.We propose solution that when
libraryquery param is present, additional blocks data will be fetched from custom url specified in this param and then added to existing milo blocks.Resolves: MWPW-161174
Test URLs:
NOTE my branch link doesn't work i have some issue with setting up AEM sync code