-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-148000] [ANALYTICS] Add analytics to Modals #3130
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3130 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 245 245
Lines 56316 56372 +56
=======================================
+ Hits 54256 54314 +58
+ Misses 2060 2058 -2 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Analytics are automatically added to main, but are modals outside of main? Modals should have analytics automatically added as well.
Resolves: MWPW-148000
QA instructions
Check Test modal for daa-lh values and links for daa-ll values.
Test URLs: