Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-148000] [ANALYTICS] Add analytics to Modals #3130

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

AdobeLinhart
Copy link
Contributor

@AdobeLinhart AdobeLinhart commented Nov 1, 2024

Analytics are automatically added to main, but are modals outside of main? Modals should have analytics automatically added as well.

  • Updated modal creation function to add analytics upon modal creation.
  • Update martech function to accept a string or index as the analytic value.

Resolves: MWPW-148000

QA instructions
Check Test modal for daa-lh values and links for daa-ll values.

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 1, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (8f0adc1) to head (c59d6e7).
Report is 19 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3130   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         245      245           
  Lines       56316    56372   +56     
=======================================
+ Hits        54256    54314   +58     
+ Misses       2060     2058    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Nov 1, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@AdobeLinhart AdobeLinhart requested a review from a team November 1, 2024 21:48
@markpadbe markpadbe self-requested a review November 2, 2024 00:06
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/martech/attributes.js Outdated Show resolved Hide resolved
Copy link
Contributor

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markpadbe markpadbe requested a review from a team November 4, 2024 21:57
@AdobeLinhart AdobeLinhart added verified PR has been E2E tested by a reviewer Ready for Stage labels Nov 4, 2024
libs/blocks/modal/modal.js Outdated Show resolved Hide resolved
@milo-pr-merge milo-pr-merge bot merged commit 2407bf6 into stage Nov 6, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the modalanalytics branch November 6, 2024 09:17
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants