Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for clients to add their own stage domain maps #3134

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

bandana147
Copy link
Contributor

@bandana147 bandana147 added needs-verification PR requires E2E testing by a reviewer high priority Why is this a high priority? Blocker? Critical? Dependency? labels Nov 4, 2024
Copy link
Contributor

aem-code-sync bot commented Nov 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 4, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (d809cd5) to head (2c2c082).
Report is 9 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3134      +/-   ##
==========================================
- Coverage   96.35%   96.33%   -0.02%     
==========================================
  Files         245      245              
  Lines       56316    56321       +5     
==========================================
- Hits        54261    54258       -3     
- Misses       2055     2063       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Nov 4, 2024
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Nov 4, 2024
@milo-pr-merge milo-pr-merge bot merged commit 6e7c03c into stage Nov 4, 2024
23 checks passed
@milo-pr-merge milo-pr-merge bot deleted the stage-domain-config branch November 4, 2024 17:50
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants