MWPW-161355: Update MAS documentation #3135

yesil · 2024-11-04T14:39:30Z

Example with contextual menu
Checkout click event with correct event target
when the CTA contains a text wrapped by a span

This PR depends on #3117
Resolves: MWPW-161355

Test URLs:

to support all cta styles organise code and code coverage Update tests

* Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span

aem-code-sync · 2024-11-04T14:39:34Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

1e314be ✅ (latest)
77817de ✅
ff6fbac ✅
a4bb64b ✅
401da98 ✅
e0a6a1f ✅
bcd598d ✅
c95e253 ✅
0f6cad4 ✅
f444044 ✅
609a94b ✅
697b6c7 ✅
7284833 ✅
cf810ee ✅
cf93529 ✅
88d263e ✅
8a1068e ✅
68f1bc3 ✅
efbecf0 ✅
ca1f4da ✅
aa229f3 ✅
d84159b ✅
d7948a6 ✅
d20385e ✅
f1f6c31 ✅
804dfe2 ❌
05d6b03 ❌
71d34fb ❌
33e802c ❌
9037667 ❌

aem-code-sync · 2024-11-04T14:39:53Z

	Page	Scores	Audits	Google
📱	/libs/features/mas/docs/mas.html?martech=off
🖥️	/libs/features/mas/docs/mas.html?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/src/variants/catalog.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/src/variants/ccd-action.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/src/variants/special-offer.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/d20385e5faf0ca722f714d6507605a06ef989492/libs/features/mas/web-components/test/mas.js

github-actions · 2024-11-04T14:40:05Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-04T14:40:08Z

libs/features/mas/commerce/src/inline-price.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-04T14:40:10Z

libs/features/mas/commerce/test/price.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-04T14:40:11Z

libs/features/mas/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-11-04T14:40:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (6f4d98c) to head (c8e3137).
Report is 1 commits behind head on ccd.

Additional details and impacted files

@@            Coverage Diff             @@
##              ccd    #3135      +/-   ##
==========================================
- Coverage   96.37%   96.34%   -0.04%     
==========================================
  Files         245      243       -2     
  Lines       56716    56641      -75     
==========================================
- Hits        54661    54570      -91     
- Misses       2055     2071      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

3ch023

accidentally found today, maybe you can fix?
https://github.com/adobecom/milo/pull/3135/files#diff-9dfd2483190876c1882dcc6ff9ea6db8448716d8fcd58de0af78dfea3b8946ecL37

(merch-card.md, line 37)

target should be e.target

yesil · 2024-11-06T15:43:16Z

@3ch023 actually I'm waiting #3117 to be merged and I'll refresh this one after.

also, sorry for the confusion, actually target is the dom element for the logger that is declared above.

github-actions · 2024-11-15T10:48:09Z

libs/features/mas/mocks/aem.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-15T10:48:10Z

libs/features/mas/web-components/src/aem-fragment.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-15T10:48:11Z

libs/features/mas/web-components/src/variants/variants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-15T10:48:12Z

libs/features/mas/web-components/test/aem-fragment.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

yesil · 2024-11-15T12:15:45Z

libs/features/mas/web-components/src/hydrate.js

@@ -169,12 +169,13 @@ function createSpectrumButton(cta, strong, aemFragmentMapping, cardVariant) {
        treatment = 'outline';
    }

+    cta.tabIndex = -1;


@Axelcureno FYI, a11y fix.

github-actions · 2024-11-15T12:27:09Z

libs/features/mas/web-components/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-15T12:42:46Z

libs/features/mas/web-components/src/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-15T12:42:47Z

libs/features/mas/web-components/src/variants/variant-layout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-18T10:29:41Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-18T10:29:41Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

* MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (#3282) * bump to 10 seconds * new change * MWPW-161645: lana logging for CCD (#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * add build artifacts --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com>

* MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (adobecom#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (adobecom#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (adobecom#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (adobecom#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (adobecom#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (adobecom#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (adobecom#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (adobecom#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (adobecom#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (adobecom#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (adobecom#3282) * bump to 10 seconds * new change * MWPW-161645: lana logging for CCD (adobecom#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * add build artifacts --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com>

yesil added 7 commits October 30, 2024 14:01

MWPW-159374: Update hydrate logic

9037667

to support all cta styles organise code and code coverage Update tests

add workaround for ccd-suggested cards

33e802c

remove source maps

71d34fb

improve code coverage

05d6b03

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

804dfe2

merge MWPW-159374

f1f6c31

MWPW-161355: Update MAS documentation

d20385e

* Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span

yesil added the commerce label Nov 4, 2024

github-actions bot reviewed Nov 4, 2024

View reviewed changes

yesil added 5 commits November 5, 2024 08:59

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

d7948a6

cleanup all attributes during card hydration

d84159b

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

aa229f3

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

ca1f4da

Merge branch 'MWPW-159374' into MWPW-161355

efbecf0

aem-code-sync bot temporarily deployed to MWPW-161355 November 6, 2024 09:26 Inactive

remove deps/mas/mas.js

68f1bc3

aem-code-sync bot temporarily deployed to MWPW-161355 November 6, 2024 09:54 Inactive

update test

8a1068e

aem-code-sync bot temporarily deployed to MWPW-161355 November 6, 2024 10:36 Inactive

3ch023 reviewed Nov 6, 2024

View reviewed changes

update doc

88d263e

aem-code-sync bot temporarily deployed to MWPW-161355 November 6, 2024 16:06 Inactive

aem-code-sync bot temporarily deployed to MWPW-161355 November 15, 2024 10:47 Inactive

github-actions bot reviewed Nov 15, 2024

View reviewed changes

yesil commented Nov 15, 2024

View reviewed changes

fix css with checkout-link

40368bb

aem-code-sync bot temporarily deployed to MWPW-161355 November 15, 2024 12:26 Inactive

github-actions bot reviewed Nov 15, 2024

View reviewed changes

fix random rtl issue

e83b466

github-actions bot reviewed Nov 15, 2024

View reviewed changes

Axelcureno approved these changes Nov 15, 2024

View reviewed changes

revert removal of mas.js from deps

9b0cbde

yesil changed the base branch from stage to ccd November 18, 2024 10:29

github-actions bot reviewed Nov 18, 2024

View reviewed changes

yesil mentioned this pull request Nov 18, 2024

MWPW-159191: MAS Freyja support #3209

Merged

update ccd gallery

c8e3137

afmicka added verified PR has been E2E tested by a reviewer run-nala-on-milo run-nala Run Nala Test Automation against PR run-milo-live Run Milo Test Nala and removed run-nala-on-milo run-nala Run Nala Test Automation against PR run-milo-live Run Milo Test Nala labels Nov 18, 2024

yesil merged commit e445eed into ccd Nov 18, 2024
35 of 36 checks passed

yesil deleted the MWPW-161355 branch November 18, 2024 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-161355: Update MAS documentation #3135

MWPW-161355: Update MAS documentation #3135

yesil commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Nov 4, 2024

github-actions bot Nov 4, 2024

github-actions bot Nov 4, 2024

github-actions bot Nov 4, 2024

codecov bot commented Nov 4, 2024 •

edited

Loading

3ch023 left a comment •

edited

Loading

yesil commented Nov 6, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 15, 2024

yesil Nov 15, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 15, 2024

github-actions bot Nov 18, 2024

github-actions bot Nov 18, 2024

MWPW-161355: Update MAS documentation #3135

MWPW-161355: Update MAS documentation #3135

Conversation

yesil commented Nov 4, 2024 • edited Loading

aem-code-sync bot commented Nov 4, 2024 • edited Loading

aem-code-sync bot commented Nov 4, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot Nov 4, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 4, 2024 • edited Loading

Codecov Report

3ch023 left a comment • edited Loading

Choose a reason for hiding this comment

yesil commented Nov 6, 2024

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

yesil Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

yesil commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

codecov bot commented Nov 4, 2024 •

edited

Loading

3ch023 left a comment •

edited

Loading