Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nala] Fix failing promo code in Nala tests #3149

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

afmicka
Copy link
Contributor

@afmicka afmicka commented Nov 6, 2024

Fixing failing promo code in Nala tests

URL for testing:

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (f12d8ec) to head (ca778dd).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3149   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         245      245           
  Lines       56374    56374           
=======================================
+ Hits        54316    54320    +4     
+ Misses       2058     2054    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Nov 6, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mokimo
Copy link
Contributor

mokimo commented Nov 6, 2024

Merging this in discussion with @afmicka to fix one failing test. Tests tail for unrelated // setup reasons, so it's fine to merge for now.

@mokimo mokimo merged commit e64bef6 into adobecom:stage Nov 6, 2024
14 of 15 checks passed
@mokimo mokimo mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants