Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding main menu placeholder #3157

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Adding main menu placeholder #3157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2122ce
Adding main menu placeholder
bandana147 Nov 7, 2024
096eecf
Avoiding replaceText if localNav
bandana147 Nov 7, 2024
8a44013
Lint fix
bandana147 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libs/blocks/global-navigation/utilities/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export const [setUserProfile, getUserProfile] = (() => {
];
})();

export const transformTemplateToMobile = (popup, item, localnav = false) => {
export const transformTemplateToMobile = async (popup, item, localnav = false) => {
const originalContent = popup.innerHTML;
const tabs = [...popup.querySelectorAll('.feds-menu-section')]
.filter((section) => !section.querySelector('.feds-promo') && section.textContent)
Expand All @@ -424,7 +424,7 @@ export const transformTemplateToMobile = (popup, item, localnav = false) => {
return { name, links };
});
const CTA = popup.querySelector('.feds-cta')?.outerHTML ?? '';
const mainmenu = `
const mainMenu = `
<span class="main-menu">
<svg xmlns="http://www.w3.org/2000/svg" style="translate:0 3px" width="7" height="12" viewBox="0 0 7 12" fill="none"><path d="M5.55579 1L1.09618 5.45961C1.05728 5.4985 1.0571 5.56151 1.09577 5.60062L5.51027 10.0661" stroke="black" stroke-width="2" stroke-linecap="round"/></svg>
{{main-menu}}
Expand All @@ -434,7 +434,7 @@ export const transformTemplateToMobile = (popup, item, localnav = false) => {
const breadCrumbs = document.querySelector('.feds-breadcrumbs')?.outerHTML;
popup.innerHTML = `
<div class="top-bar">
${localnav ? brand : mainmenu}
${localnav ? brand : await replaceText(mainMenu, getFedsPlaceholderConfig())}
<span class="close-icon" style="width:11.5px;height:11.5px;padding:12px;cursor:pointer">
<svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 14 14" fill="none">
<path d="M1.5 1L13 12.5" stroke="black" stroke-width="1.7037" stroke-linecap="round"/>
Expand All @@ -443,7 +443,7 @@ export const transformTemplateToMobile = (popup, item, localnav = false) => {
</span>
</div>
<div class="title">
${breadCrumbs ? breadCrumbs : `<div class="breadcrumbs"></div>`}
${breadCrumbs || `<div class="breadcrumbs"></div>`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.

Suggested change
${breadCrumbs || `<div class="breadcrumbs"></div>`}
${breadCrumbs || '<div class="breadcrumbs"></div>'}

<h7>${item.textContent.trim()}</h7>
</div>
<div class="tabs" role="tablist">
Expand Down
Loading