-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157506: Localized Placeholder Texts on English Pages #3177
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3177 +/- ##
==========================================
+ Coverage 96.38% 96.43% +0.04%
==========================================
Files 245 245
Lines 56651 56738 +87
==========================================
+ Hits 54601 54713 +112
+ Misses 2050 2025 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "after" page 404s for me: https://mwpw-157506--milo--adobecom.hlx.page/drafts/siva/157506/placeholder-example
CC before/after checks out:
axe unnecessary regex in test.
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Closing this PR due to inactivity. |
Validation done on the pr and results are added in subtask Below authoring guidelines is provided |
disable-geo-placeholders
meta tag."off"
, the application receives geo-specific placeholders. If the tag is set to"on"
, it defaults to generic placeholders.Resolves: MWPW-157506
GH: https://github.com/orgs/adobecom/discussions/2791
Test URLs:
Milo
CC