Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157506: Localized Placeholder Texts on English Pages #3177

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

sivasadobe
Copy link
Contributor

@sivasadobe sivasadobe commented Nov 12, 2024

  • Adds functionality to conditionally use geo-specific placeholders based on disable-geo-placeholders meta tag.
  • If the tag is absent or set to "off", the application receives geo-specific placeholders. If the tag is set to "on", it defaults to generic placeholders.

Resolves: MWPW-157506

GH: https://github.com/orgs/adobecom/discussions/2791

Test URLs:

Milo

CC

Copy link
Contributor

aem-code-sync bot commented Nov 12, 2024

Page Scores Audits Google
📱 /drafts/siva/157506/placeholder-example PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/siva/157506/placeholder-example PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (df454db) to head (bfb04cd).
Report is 36 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3177      +/-   ##
==========================================
+ Coverage   96.38%   96.43%   +0.04%     
==========================================
  Files         245      245              
  Lines       56651    56738      +87     
==========================================
+ Hits        54601    54713     +112     
+ Misses       2050     2025      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hparra hparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "after" page 404s for me: https://mwpw-157506--milo--adobecom.hlx.page/drafts/siva/157506/placeholder-example

CC before/after checks out:

Screenshot 2024-11-13 at 21 37 24 Screenshot 2024-11-13 at 21 37 37

axe unnecessary regex in test.

test/features/placeholders/placeholders.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Nov 26, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Closing this PR due to inactivity.

@github-actions github-actions bot closed this Dec 3, 2024
@sivasadobe sivasadobe reopened this Dec 3, 2024
@sivasadobe sivasadobe removed the Stale label Dec 3, 2024
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Dec 3, 2024
@milo-pr-merge milo-pr-merge bot merged commit 4057fef into adobecom:stage Dec 3, 2024
35 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants