[MWPW-161858] - fix: [Sticky bottom issues with high resolution with short content page]

[saugatmalla]

From MWPW-161858: When the footer is in the view screen, a block with sticky-bottom to add "hide-sticky-section" and display none.

Resolves: MWPW-161858

Test URLs:

• Before: https://www.stage.adobe.com/products/special-offers.html
• After: https://main--cc--adobecom.hlx.page/products/special-offers?milolibs=smalla-MWPW-161858-sticky&martech=off

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 7017b24 ✅ (latest)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (1fa592a) to head (7017b24).
Report is 731 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3191      +/-   ##
==========================================
+ Coverage   95.69%   96.37%   +0.68%     
==========================================
  Files         165      245      +80     
  Lines       43542    56613   +13071     
==========================================
+ Hits        41668    54563   +12895     
- Misses       1874     2050     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[robert-bogos]

I think we can reduce the complexity for this, and not cache isFooterStart:

Suggested change

	if (entry.target === document.querySelector('footer')) {
	isFooterStart = entry.isIntersecting;
	}
	if (entry.isIntersecting || abovePromoStart || isFooterStart) el.classList.add('hide-sticky-section');
	if (entry.isIntersecting ||
	abovePromoStart ||
	(entry.target === document.querySelector('footer') && entry.isIntersecting)) {
	el.classList.add('hide-sticky-section');
	}

[github-actions]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

[github-actions]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

[robert-bogos]

A new PR was opened for this issue: #3402