Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162833 [nala][MEP] confirm the "any-marquee-section" selector #3229

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Nov 20, 2024

This nala tests checks the "any-marquee-section" selector per PR request 2884:

Resolves: MWPW-162833

Test URLs:

Here is an example of the nala test:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/any-marquee-section/any-marquee-section
compare with the default base page: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/any-marquee-section/any-marquee-section?mep=%2Fdrafts%2Fnala%2Ffeatures%2Fpersonalization%2Fany-marquee-section%2Fany-marquee-section.json--default

Note how every type of marquee is listed on the base page and that all marquee types are replaced with text by using the any-marquee-section selector in the MEP manifest

Copy link
Contributor

aem-code-sync bot commented Nov 20, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 20, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (35d79cf).
Report is 5 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3229   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         245      245           
  Lines       56716    56716           
=======================================
+ Hits        54661    54665    +4     
+ Misses       2055     2051    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpratt2
Copy link
Contributor Author

jpratt2 commented Nov 20, 2024

@skumar09 Please let me know if you accept how I used CSS locators within this test.

@aem-code-sync aem-code-sync bot temporarily deployed to any-marquee-section November 20, 2024 18:16 Inactive
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@jpratt2 jpratt2 added Ready for Stage verified PR has been E2E tested by a reviewer labels Nov 22, 2024
@milo-pr-merge milo-pr-merge bot merged commit 488a6b2 into stage Nov 30, 2024
24 checks passed
@milo-pr-merge milo-pr-merge bot deleted the any-marquee-section branch November 30, 2024 08:13
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants