-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162833 [nala][MEP] confirm the "any-marquee-section" selector #3229
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3229 +/- ##
=======================================
Coverage 96.37% 96.38%
=======================================
Files 245 245
Lines 56716 56716
=======================================
+ Hits 54661 54665 +4
+ Misses 2055 2051 -4 ☔ View full report in Codecov by Sentry. |
@skumar09 Please let me know if you accept how I used CSS locators within this test. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
This nala tests checks the "any-marquee-section" selector per PR request 2884:
Resolves: MWPW-162833
Test URLs:
Here is an example of the nala test:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/any-marquee-section/any-marquee-section
compare with the default base page: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/any-marquee-section/any-marquee-section?mep=%2Fdrafts%2Fnala%2Ffeatures%2Fpersonalization%2Fany-marquee-section%2Fany-marquee-section.json--default
Note how every type of marquee is listed on the base page and that all marquee types are replaced with text by using the any-marquee-section selector in the MEP manifest