Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel update for SharePoint video sizing #3265

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Carousel update for SharePoint video sizing #3265

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf5e17d
Adding video fill variant
Nov 25, 2024
7919167
PR feedback, css clean up
Nov 27, 2024
e5538ef
Merge branch 'stage' into carousel-video-sizing
Dec 9, 2024
fd9f684
Fixing code conflicts with https://github.com/adobecom/milo/pull/3053
Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions libs/blocks/carousel/carousel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,36 +373,38 @@ html[dir="rtl"] .carousel-slides .section.carousel-slide {
width: unset;
}

.carousel.rounded-corners .carousel-slide,
.carousel.rounded-corners .carousel-slide > div :is(p):has(> picture) img {
.carousel:is(.rounded-corners, .m-rounded-corners) .carousel-slide,
.carousel:is(.rounded-corners, .m-rounded-corners) .carousel-slide > div :is(p > picture img, p > video, p > .milo-video, p > .video-holder video) {
border-radius: var(--m-rounded-corners);
}

.carousel.l-rounded-corners .carousel-slide,
.carousel.l-rounded-corners .carousel-slide > div :is(p):has(> picture) img {
border-radius: var(--l-rounded-corners);
.carousel[class*='rounded-corners'] .carousel-slide,
.carousel[class*='rounded-corners'] .carousel-slide > div :is(p > video, p > .milo-video, p > .video-holder video) {
overflow: hidden;
}

.carousel.s-rounded-corners .carousel-slide,
.carousel.s-rounded-corners .carousel-slide > div :is(p):has(> picture) img {
.carousel.s-rounded-corners .carousel-slide > div :is(p > picture img, p > video, p > .milo-video, p > .video-holder video) {
border-radius: var(--s-rounded-corners);
}

.carousel.full-rounded-corners .carousel-slide,
.carousel.full-rounded-corners .carousel-slide > div :is(p):has(> picture) img {
border-radius: var(--full-rounded-corners);
.carousel.l-rounded-corners .carousel-slide,
.carousel.l-rounded-corners .carousel-slide > div :is(p > picture img, p > video, p > .milo-video, p > .video-holder video) {
border-radius: var(--l-rounded-corners);
}

.carousel[class*='rounded-corners'] .carousel-slide {
overflow: hidden;
.carousel.full-rounded-corners .carousel-slide,
.carousel.full-rounded-corners .carousel-slide > div :is(p > picture img, p > video, p > .milo-video, p > .video-holder video) {
border-radius: var(--full-rounded-corners);
}

.carousel .carousel-slide > div p :is(.video-holder, video) {
.carousel.video-fill .carousel-slide > div p :is(.video-holder, video),
.carousel .carousel-slide.video-fill > div p :is(.video-holder, video) {
width: 100%;
height: auto;
}

.carousel[class*='rounded-corners'] .carousel-slide > div :is(p):has(> video, > picture, > .milo-video, > .modal-img-link) {
.carousel[class*='rounded-corners'] .carousel-slide > div :is(p):has(> video, > picture, > .milo-video, > .modal-img-link, > .video-holder) {
margin-top: 0;
margin-bottom: 0;
line-height: 0;
Expand Down
Loading