-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-163379: Fix edit url from Helix admin API for DA #3314
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. There's a da-bacom
link before and milo
link after ... those are two different projects with different content. Using the milolibs
param, you should be able to consume your branch's sidekick on a consumer
The issue is reported on the 'da-bacom' which uses content from DA. The after link for Milo is specifically for checking regression since the code change will be affecting both milo and da-bacom sites. (Refer the heading "Regression" above the after URL). |
This would be your after link https://main--da-bacom--adobecom.aem.page/drafts/ancy/content-analytics?milolibs=mwpw-163379--milo--sharmeeatadobe you can have multiple before/after links for each project/consumer. |
Great! Thankful for this @mokimo , let me update |
function getDAEditUrl(sourceUrl) { | ||
if (!sourceUrl) { | ||
return ''; | ||
} | ||
const daEditUrl = sourceUrl.replace('markup:https://content.da.live', 'https://da.live/edit#'); | ||
return daEditUrl; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be simplified?
function getDAEditUrl(sourceUrl) {
return sourceUrl?.replace('markup:https://content.da.live', 'https://da.live/edit#') || '';
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharg1 made the suggested change
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3314 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 254 254
Lines 59031 59031
=======================================
+ Hits 56954 56955 +1
+ Misses 2077 2076 -1 ☔ View full report in Codecov by Sentry. |
What I usually do to debug failing nala tests:
|
Although the Nala tests passed after the latest pull from stage, there are unrelated failures in UTs for HelixReview.test.js |
Reminder to set the |
@@ -165,13 +169,14 @@ function Item({ name, item, idx }) { | |||
const { publishText, disablePublish } = usePublishProps(item); | |||
const isChecked = item.checked ? ' is-checked' : ''; | |||
const isFetching = item.edit ? '' : ' is-fetching'; | |||
const editIcon = item.edit && item.edit.includes(DA_DOMAIN) ? 'da-icon' : 'sharepoint-icon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
const editIcon = item.edit && item.edit.includes(DA_DOMAIN) ? 'da-icon' : 'sharepoint-icon'; | |
const editIcon = item.edit?.includes(DA_DOMAIN) ? 'da-icon' : 'sharepoint-icon'; |
preview.sourceLocation
keypreview.sourceLocation
and replacing with the edit url for DA.Resolves: MWPW-163379
Test URLs:
After