Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-163723] [NALA] Update Nala CircleCI Job to Manual Trigger #3317

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

skumar09
Copy link
Contributor

@skumar09 skumar09 commented Dec 5, 2024

  • The current CircleCI job using a self-hosted runner is experiencing issues, causing delays as the automated trigger in the pipeline frequently hangs. This impacts the merge process.
  • By default, Nala tests are already running on the stage branch as part of the pipeline, making this additional CircleCI job redundant in most cases.

Updating the workflow to use a manual trigger (workflow_dispatch) temporarily. This allows the CircleCI job to be executed only on demand, avoiding pipeline hangs while maintaining the flexibility to run the job when needed. Once the self-hosted runner issues are resolved, the automated trigger can be reinstated if required

Resolves: MWPW-163723

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (82098c7) to head (343cb90).
Report is 96 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3317   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         246      246           
  Lines       57568    57568           
=======================================
  Hits        55505    55505           
  Misses       2063     2063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 5, 2024

Error merging 3317: [MWPW-163723] [NALA] Update Nala CircleCI Job to Manual Trigger Resource not accessible by integration

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 9, 2024

Error merging 3317: [MWPW-163723] [NALA] Update Nala CircleCI Job to Manual Trigger Resource not accessible by integration

@mokimo mokimo merged commit 57d66cf into adobecom:stage Dec 9, 2024
19 checks passed
@mokimo mokimo mentioned this pull request Dec 9, 2024
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
…ecom#3317)

updating the job to manual trigger

Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants