Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161015 Adds new segment-timeline classes #3328

Merged
merged 16 commits into from
Dec 9, 2024
Merged

Conversation

markpadbe
Copy link
Contributor

@markpadbe markpadbe commented Dec 6, 2024

This ticket is marked as high priority because pages are launching 12/12 that need these updates prior to launch (for QA etc).

This PR updates the timeline block to match new design requirements by providing authors with seven classes to choose from, to set the column widths. Also, it updates the center text to switch from left aligned to right aligned adds allows the author to use one of 7 new classes (e.g., segment-timeline-4-8).

Resolves: MWPW-161015

Steps to QA:
Prior to this update, the column width was determined by the number values seen in the image blow. The QA links below all have the same number values, but with this update, the column widths will instead be based on the class that has been authored:
segment-timeline-9-3
segment-timeline-8-4
segment-timeline-7-5
segment-timeline-6-6
segment-timeline-5-7
segment-timeline-4-8
segment-timeline-3-9

Screenshot 2024-12-06 at 10 12 13 AM

QA links:
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline9-3?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline8-4?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline7-5?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline6-6?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline5-7?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline4-8?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline3-9?milolibs=timelineupdates

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 6, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (b72ed94) to head (33dcba0).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3328   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         246      246           
  Lines       57567    57587   +20     
=======================================
+ Hits        55504    55524   +20     
  Misses       2063     2063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vgoodric vgoodric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a code level, looks good.

@vgoodric vgoodric added high priority Why is this a high priority? Blocker? Critical? Dependency? verified PR has been E2E tested by a reviewer labels Dec 6, 2024
@jpratt2 jpratt2 self-assigned this Dec 6, 2024
Copy link
Contributor

@jpratt2 jpratt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the width of the bars on the various pages, and they all look good.
Approved.

@milo-pr-merge milo-pr-merge bot merged commit 02bf866 into stage Dec 9, 2024
29 checks passed
@milo-pr-merge milo-pr-merge bot deleted the timelineupdates branch December 9, 2024 09:19
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants