-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-161015 Adds new segment-timeline classes #3328
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3328 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 246 246
Lines 57567 57587 +20
=======================================
+ Hits 55504 55524 +20
Misses 2063 2063 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a code level, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the width of the bars on the various pages, and they all look good.
Approved.
This ticket is marked as high priority because pages are launching 12/12 that need these updates prior to launch (for QA etc).
This PR updates the timeline block to match new design requirements by providing authors with seven classes to choose from, to set the column widths. Also, it updates the center text to switch from left aligned to right aligned adds allows the author to use one of 7 new classes (e.g., segment-timeline-4-8).
Resolves: MWPW-161015
Steps to QA:
Prior to this update, the column width was determined by the number values seen in the image blow. The QA links below all have the same number values, but with this update, the column widths will instead be based on the class that has been authored:
segment-timeline-9-3
segment-timeline-8-4
segment-timeline-7-5
segment-timeline-6-6
segment-timeline-5-7
segment-timeline-4-8
segment-timeline-3-9
QA links:
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline9-3?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline8-4?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline7-5?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline6-6?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline5-7?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline4-8?milolibs=timelineupdates
https://main--cc--adobecom.hlx.page/drafts/markp/timelineupdates/timeline3-9?milolibs=timelineupdates
Test URLs: