-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-164097] Allow special chars in aria-label definition #3362
base: stage
Are you sure you want to change the base?
[MWPW-164097] Allow special chars in aria-label definition #3362
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3362 +/- ##
==========================================
- Coverage 96.48% 96.47% -0.01%
==========================================
Files 254 254
Lines 59029 59027 -2
==========================================
- Hits 56953 56946 -7
- Misses 2076 2081 +5 ☔ View full report in Codecov by Sentry. |
I want to make sure I understand this. Code looks great. When I look at the main branch version of your sample page, I do see the link with a special character applying the What am I missing? |
@rgclayton - yes, the correct |
Reminder to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-164097
This adapts the logic that allows authors to define
aria-label
attribute values for links, in order to allow the use of special characters. We're now using capturing groups to identify the pattern match at the end of the link's text content, which simplifies the logic and also addresses the bug.Resolves: MWPW-164097
Test URLs: