Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-164097] Allow special chars in aria-label definition #3362

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

overmyheadandbody
Copy link
Contributor

This adapts the logic that allows authors to define aria-label attribute values for links, in order to allow the use of special characters. We're now using capturing groups to identify the pattern match at the end of the link's text content, which simplifies the logic and also addresses the bug.

Resolves: MWPW-164097

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (635c26b) to head (6cf8827).
Report is 3 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3362      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files         254      254              
  Lines       59029    59027       -2     
==========================================
- Hits        56953    56946       -7     
- Misses       2076     2081       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgclayton
Copy link
Contributor

I want to make sure I understand this. Code looks great.

When I look at the main branch version of your sample page, I do see the link with a special character applying the aria-label. I was under the assumption this should not work until viewed with your new feature branch, with the updated code.

What am I missing?

image

@overmyheadandbody
Copy link
Contributor Author

@rgclayton - yes, the correct aria-label does get applied, but the link's label also contains it, so we'd get duplicate content and show details that might affect the UI or might not be relevant for all users.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Dec 13, 2024
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-164097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants