Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making localnav auto dismiss on click outside #3368

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

bandana147
Copy link
Contributor

Copy link
Contributor

aem-code-sync bot commented Dec 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 12, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mobile-gnav@2d66d29). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             mobile-gnav    #3368   +/-   ##
==============================================
  Coverage               ?   98.84%           
==============================================
  Files                  ?       70           
  Lines                  ?     8660           
  Branches               ?        0           
==============================================
  Hits                   ?     8560           
  Misses                 ?      100           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prativas22
Copy link

prativas22 commented Dec 12, 2024

Verified the LNAV close on click anywhere else functionality using below url
https://main--cc--adobecom.hlx.page/creativecloud?milolibs=localnav-auto
https://main--dc--adobecom.hlx.page/acrobat/pricing/compare-versions?milolibs=localnav-auto
below added video for reference
iPhone-LNAV-autoclose.webm

@bandana147 bandana147 merged commit aee80dc into mobile-gnav Dec 12, 2024
12 of 13 checks passed
@bandana147 bandana147 deleted the localnav-auto branch December 12, 2024 16:51
bandana147 added a commit that referenced this pull request Dec 13, 2024
* Making localnav auto dismiss on click outside

* making active link in localnav bold
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
* Making localnav auto dismiss on click outside

* making active link in localnav bold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants