[MWPW-160864] Adapt action item focus state #3398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overmyheadandbody
requested review from
narcis-radu,
mokimo,
robert-bogos and
DKos95
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3398 +/- ##
==========================================
- Coverage 96.48% 96.47% -0.01%
==========================================
Files 254 254
Lines 59031 59031
==========================================
- Hits 56954 56950 -4
- Misses 2077 2081 +4 ☔ View full report in Codecov by Sentry. |
mokimo
approved these changes
Dec 19, 2024
robert-bogos
approved these changes
Dec 20, 2024
|
Reminder to set the |
SilviuLCF
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-160864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the focus state for action items to ensure that the whole clickable area is focused when a user is tabbing through these elements. This is needed for accessibility purposes.
Resolves: MWPW-160864
Screenshots:
Note that items with floating icons will have an irregular outline when focused. I've confirmed with our accessibility experts that this is not a concern:
Test URLs: