-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-159299 Add chart role and dynamic aria labels #3404
base: stage
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3404 +/- ##
==========================================
- Coverage 96.48% 96.47% -0.01%
==========================================
Files 254 254
Lines 59031 59049 +18
==========================================
+ Hits 56954 56970 +16
- Misses 2077 2079 +2 ☔ View full report in Codecov by Sentry. |
Reminder to set the |
Testing note: Extra data is included in the label, once the echarts feature
excludeDimensionId
is released we can filter it out. Currently, each series data contains the index numbers alongside all dimensions, so it is limited to one series with a custom template to avoid redundancy.Resolves: MWPW-159299
Test URLs:
BACOM URLs: