Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159299 Add chart role and dynamic aria labels #3404

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from

Conversation

Brandon32
Copy link
Contributor

@Brandon32 Brandon32 commented Dec 20, 2024

  • Add 'img' role to charts required for aria label
  • Update echarts library and enable dynamic aria labels

Testing note: Extra data is included in the label, once the echarts feature excludeDimensionId is released we can filter it out. Currently, each series data contains the index numbers alongside all dimensions, so it is limited to one series with a custom template to avoid redundancy.

Resolves: MWPW-159299

Test URLs:

BACOM URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 20, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 20, 2024

Page Scores Audits Google
📱 /drafts/bmarshal/chart?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/bmarshal/chart?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (d543279) to head (2346b6e).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3404      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files         254      254              
  Lines       59031    59049      +18     
==========================================
+ Hits        56954    56970      +16     
- Misses       2077     2079       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@chart Milo chart block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants