[MWPW-163381] : Removed lorem ipsum text check from preflight modal #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3417 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 255 255
Lines 59253 59253
=======================================
Hits 57163 57163
Misses 2090 2090 ☔ View full report in Codecov by Sentry. |
|
sharmeeatadobe
changed the title
mokimo
approved these changes
Jan 3, 2025
narcis-radu
approved these changes
Jan 10, 2025
|
Reminder to set the |
SilviuLCF
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Ready for STAGE
Testing details
https://jira.corp.adobe.com/browse/MWPW-163381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preflight dialog is added to the body of the actual page. And currently the lorem ipsum text is checked inside the entire innerHTML (thus including the preflight dialog). So once the preflight dialog opens for the first time it introduces the "Lorem Ipsum" text in the body and hence for all consecutive checks, it incorrectly fails even if the page does not have the "Lorem Ipsum" text.
Handled it by eliminating the preflight dialog content and checking in the actual body of the page instead.
Resolves: MWPW-163381
Test URLs: