Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package version for bundled standalone gnav #3423

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bandana147
Copy link
Contributor

  • Updating package version for bundled standalone gnav

Test URLs:

@bandana147 bandana147 added trivial PR doesn't require E2E testing by a reviewer zero-impact labels Jan 7, 2025
Copy link
Contributor

aem-code-sync bot commented Jan 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

Copy link
Contributor

aem-code-sync bot commented Jan 7, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bandana147 bandana147 requested a review from salonijain3 January 7, 2025 10:43
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (82694a3) to head (12b59ee).
Report is 17 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3423   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         255      255           
  Lines       59363    59363           
=======================================
  Hits        57266    57266           
  Misses       2097     2097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milo-pr-merge milo-pr-merge bot merged commit 239f08a into stage Jan 13, 2025
30 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-version branch January 13, 2025 08:23
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants