Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification pill variant needs 16px spacing below it #3445

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

rgclayton
Copy link
Contributor

Adding a 16px spacing between the pill notification and the bottom of the browser to get it the appearance of "floating.

Note: The ribbon notification variant does not get this spacing.

Resolves: MWPW-163581

Test URLs:

image

Copy link
Contributor

aem-code-sync bot commented Jan 9, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 9, 2025

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (a2443c0) to head (2077644).
Report is 26 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3445      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.01%     
==========================================
  Files         255      255              
  Lines       59253    59420     +167     
==========================================
+ Hits        57163    57319     +156     
- Misses       2090     2101      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa
Copy link

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 10, 2025
@milo-pr-merge milo-pr-merge bot merged commit ef0d2ce into stage Jan 13, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot deleted the pill-notification-padding branch January 13, 2025 08:24
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants