Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding save today to ctaTextOption #3458

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Adding save today to ctaTextOption #3458

merged 2 commits into from
Jan 13, 2025

Conversation

seanchoi-dev
Copy link
Contributor

@seanchoi-dev seanchoi-dev requested a review from a team as a code owner January 10, 2025 10:44
Copy link
Contributor

aem-code-sync bot commented Jan 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@seanchoi-dev seanchoi-dev requested a review from 3ch023 January 10, 2025 10:44
Copy link
Contributor

aem-code-sync bot commented Jan 10, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@seanchoi-dev seanchoi-dev added the trivial PR doesn't require E2E testing by a reviewer label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (c582faa) to head (2b762cf).
Report is 6 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3458   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         255      255           
  Lines       59420    59421    +1     
=======================================
+ Hits        57314    57315    +1     
  Misses       2106     2106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 11, 2025
@milo-pr-merge milo-pr-merge bot merged commit be5c164 into stage Jan 13, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-164811 branch January 13, 2025 08:24
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage trivial PR doesn't require E2E testing by a reviewer verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants