-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENB-7652] Refactor flags and methods #3498
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3498 +/- ##
==========================================
+ Coverage 96.47% 96.49% +0.02%
==========================================
Files 260 260
Lines 60582 60603 +21
==========================================
+ Hits 58444 58481 +37
+ Misses 2138 2122 -16 ☔ View full report in Codecov by Sentry. |
fbe6994
to
c835da7
Compare
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
c835da7
to
f70653b
Compare
239ae41
to
96d7c65
Compare
8e7e688
to
e94c3e7
Compare
Skipped merging 3498: [ENB-7652] Refactor flags and methods due to insufficient approvals. Required: 2 approvals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified all scenarios in QA environment. Hence Approved it.
@swamu I think it would be better to add the pzn v2 flag in config.mep and pull it back out of config when possible instead of passing it to so many functions. if you look at the top of the init function in personalization.js you'll see we add several settings for later use related to MEP. It feels like this will also make it easier to remove later if we fully roll the feature out. Also wondering if we want to leverage the utils.js function |
@vgoodric , noted and updated with both the points |
Retested all new commits, Good to Merge. |
Add pageview send event, fix window.satellite empty issue
https://main--cc--adobecom.hlx.live/drafts/suhjain/swati-pages/photoshop-v2?target=on&milolibs=ENB-7652-refactor-enablePerseV2--milo--swamu#
Resolves: ENB-7652
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://ENB-7652-refactor-enablePerseV2--milo--swamu.aem.page/?martech=off