MWPW-164131: Adding aria label for CTA using placeholder on name attributes of merch card

[seanchoi-dev]

Resolves: MWPW-164131

Test URLs:

• Before: https://main--milo--adobecom.aem.page/drafts/seanchoi/merch-card-comm?martech=off
• After: https://MWPW-164131--milo--adobecom.aem.page/drafts/seanchoi/merch-card-comm?martech=off

Test for consumer URLs:

• https://main--cc--adobecom.hlx.page/products/special-offers?martech=off&milolibs=MWPW-164131
• https://main--cc--adobecom.hlx.page/products/catalog?martech=off&milolibs=MWPW-164131
• https://main--cc--adobecom.hlx.page/drafts/fredw/sean-test-cta?milolibs=MWPW-164131

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 69e30d6 ✅ (latest)
• 035f8b2 ✅
• b1baae5 ✅
• 8b0843d ✅
• 4b7b53d ✅
• 37715d4 ✅
• 8aff28b ✅
• 02d1594 ✅
• 33c19f8 ✅
• b5b50ad ✅
• 2cf9f9a ✅
• 886bec8 ✅
• 9f96bd7 ✅
• f62be2e ✅

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/drafts/seanchoi/merch-card-comm?martech=off
🖥️	/drafts/seanchoi/merch-card-comm?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (a4101ed) to head (69e30d6).
Report is 12 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3505      +/-   ##
==========================================
+ Coverage   96.47%   96.48%   +0.01%     
==========================================
  Files         260      260              
  Lines       60415    60597     +182     
==========================================
+ Hits        58284    58466     +182     
  Misses       2131     2131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[npeltier]

lgtm

[3ch023]

I think this logic should be in merch block (merch.js), not in merch-card block.
there are Merch CTAs outside of merch-cards and we could set a aria-label for them authomatically which means less authoring effort.

you could add it in the end of buildCTA method https://github.com/adobecom/milo/blob/stage/libs/blocks/merch/merch.js#L723
you can use 'onceSettled' promise on merch link, e.g. cta.onceSettled().then(...set aria-label);

we could and probably should have done it even deeper, in checkout-link/checkout-button web component, but imo for now Milo level of merch block is good enough.