Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-162043] Bolded last link in Media block #3517

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

overmyheadandbody
Copy link
Contributor

Using an actual heading in the Media block leads to different text treatment as opposed to using a paragraph as a heading. Depending on this, the simple link on the last line of the text section can have either a bold or a regular font weight.

The aim of this PR is to ensure that all such regular links are bolded by default. This treatment may be required in other areas as well, but it was decided to handle just this use-case for the moment.

Resolves: MWPW-162043

Test URLs:

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (a4101ed) to head (bcf27b4).
Report is 12 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3517      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.02%     
==========================================
  Files         260      260              
  Lines       60415    60415              
==========================================
- Hits        58284    58277       -7     
- Misses       2131     2138       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Jan 24, 2025
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-162043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants