Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-166027] - Add empty space if the logo is undefined #3528

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

Deva309
Copy link
Contributor

@Deva309 Deva309 commented Jan 23, 2025

In some cases the logo is coming as undefined for the new mobile GNAV.
We have added a empty space instead of 'undefined' text showing in the new Mobile GNAV.
Error Screenshot:
IMG_3226-1

Resolves: MWPW-166027

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 23, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (a4101ed) to head (12a4f5b).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3528   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         260      260           
  Lines       60415    60416    +1     
=======================================
+ Hits        58284    58285    +1     
  Misses       2131     2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants