[MWPW-166151] Mobile gnav links transformations #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3529 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 260 260
Lines 60415 60415
=======================================
Hits 58284 58284
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
bandana147
approved these changes
Jan 23, 2025
overmyheadandbody
approved these changes
Jan 23, 2025
SilviuLCF
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Ready to STAGE, testing details
https://jira.corp.adobe.com/browse/MWPW-166151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where part of the non-localized URL pathname matches the current locale, leading to unwanted link transformations.
Related Issue
Resolves: MWPW-166151
Testing instructions
1.Launch the after URL
2.Log in with the stage account shared in the Jira ticket description.
3.Make sure gnav is visible.
4.Change the locale from english to Suomi.
5.Click on files tab ("Tiedostot") in side nav.
6.Should not lead to a 404 page.
Screenshots:
Before:
After:
Test URLs
PSI check URL: https://mwpw-166151-stage-links-conversion--milo--adobecom.hlx.page/drafts/rbogos/page-default?martech=off