MWPW-108710 - Handle Emdashes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change makeRelative to swap emdashes for double hyphen. Resolves: MWPW-108710
|
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 94.00% 94.01% +0.01%
==========================================
Files 6 6
Lines 350 351 +1
==========================================
+ Hits 329 330 +1
Misses 21 21
Continue to review full report at Codecov.
|
auniverseaway
requested review from
fullcolorcoder,
janaki-r-bhagwath and
seanchoi-dev
seanchoi-dev
approved these changes
Apr 22, 2022
Axelcureno
added a commit
that referenced
this pull request
Apr 17, 2024
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
#3258) * move common snippets to helper, add defer logic and make interact call the 1st thing in the flow for signed out users * toggle FPID and ECID logic, re-organise exports, dont fire if consent cookie present * Pre merge branch (#5) move methods utils , use async load of helper, review comments * move try catch block as per promise * Pre merge branch (#6) * Test remove martech logic (#7) fix delay logic, fix pr comments * Test remove martech logic (#8) change uuid logic, promise structure, alloy response logic, requestid, * Final local branch (#9) fix review comments, add test cases * fix coverage for if check * fix coverage errors * add test case for martech helpers * send full cookie flag added post testing round 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-108710
Test URLs: