fix: Respect contracts directory defined in adonisjrc.json #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
ping @thetutlage |
RomainLanz
requested changes
Feb 6, 2023
| @@ -126,7 +126,8 @@ export default async function instructions( | |||
| /** | |||
| * Create the mail contracts file | |||
| */ | |||
| const contractsPath = app.makePath('contracts/mail.ts') | |||
| const contractsDir = app.directoriesMap.get('contracts') || 'contracts' | |||
There was a problem hiding this comment.
Can we use path.join instead?
Suggested change
| const contractsDir = app.directoriesMap.get('contracts') || 'contracts' | |
| const contractsDirectory = app.directoriesMap.get('contracts') || 'contracts' | |
| const contractPath = join(contractsDirectory, 'mail.ts') |
| @@ -141,7 +142,7 @@ export default async function instructions( | |||
| sparkpost: mailDrivers.includes('sparkpost'), | |||
| }) | |||
| .commit() | |||
| sink.logger.action('create').succeeded('contracts/mail.ts') | |||
| sink.logger.action('create').succeeded(`${contractsDir}/mail.ts`) | |||
There was a problem hiding this comment.
Suggested change
| sink.logger.action('create').succeeded(`${contractsDir}/mail.ts`) | |
| sink.logger.action('create').succeeded(contractPath) |
Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@TiBianMod Thanks for the PR and sorry for taking that long :) |
|
@thetutlage no problem mate 😄 |
RomainLanz
pushed a commit
that referenced
this pull request
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node ace configure @adonisjs/mailignores the definedcontractsdirectory from the user inside.adonisjrc.jsonThis PR will respect the
contractsdirectory defined by the user inside.adonisjrc.jsonand will fallback to default if not present.Types of changes
Checklist
Further comments
@thetutlage point me to right direction for adding tests if necessary.
I can't find related tests for
node ace configure @adonisjs/mail