chore: Make ESLint config more standard (#410)

* chore: Make ESLint config more standard

* Remove ESLint dep to align with Ember

* Allow ember-cli

* Update .eslintrc.js

.eslintrc.js

@@ -18,22 +18,16 @@ module.exports = {
   env: {
     es6: true,
     qunit: true,
-    node: true,
+    node: true
   },
   globals: {
     // Electron
     'requireNode': true,
     'processNode': true
   },
   rules: {
-    'ember/no-const-outside-module-scope': 'off',
-    'ember/no-direct-property-access': 'off',
-    'ember/avoid-leaking-state-in-ember-objects': 'warn', // TODO: Remove after upgrading eslint >= 4.2.0
     'ember/no-jquery': 'error',
-    'ember/require-access-in-comments': 'off',
-    'newline-before-return': 'error',
-    'no-console': 'off',
-    'one-var': 'off',
+    'no-console': 'off'
   },
   overrides: [
     // node files
@@ -46,6 +40,7 @@ module.exports = {
         'testem.js',
         'blueprints/*/index.js',
         'config/**/*.js',
+        'lib/commands/*.js',
         'tests/dummy/config/**/*.js'
       ],
       excludedFiles: [
@@ -65,6 +60,9 @@ module.exports = {
       rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
         // add your custom rules and overrides for node files here
         'ember/avoid-leaking-state-in-ember-objects': 'off',
+        'node/no-unpublished-require': ['error', {
+          'allowModules': ['ember-cli']
+        }]
       })
     }
   ]

lib/models/assembler.js

@@ -1,4 +1,3 @@
-/* eslint-disable ember-suave/prefer-destructuring, newline-before-return, arrow-parens */
 'use strict';
 const exit = require('capture-exit');
 exit.captureExit();

package.json

@@ -115,10 +115,7 @@
     "ember-source": "~3.14.1",
     "ember-source-channel-url": "^2.0.1",
     "ember-try": "^1.2.1",
-    "eslint": "^4.18.2",
-    "eslint-config-ember": "^0.3.0",
-    "eslint-plugin-ember": "^7.1.0",
-    "eslint-plugin-ember-suave": "^1.0.0",
+    "eslint-plugin-ember": "^7.5.0",
     "eslint-plugin-node": "^10.0.0",
     "loader.js": "^4.7.0",
     "mocha": "^3.5.3",