Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use full path to node for launcher #750

Closed
rwjblue opened this issue Mar 3, 2021 · 3 comments · Fixed by #751
Closed

Should use full path to node for launcher #750

rwjblue opened this issue Mar 3, 2021 · 3 comments · Fixed by #751
Assignees
@bendemboski

Comments

@rwjblue
Copy link
Member

rwjblue commented Mar 3, 2021

ember-electron/lib/test-runner.js

Line 23 in 98e9237

exe: 'node',

Should be:

  exe: process.execPath,
@RobbieTheWagner
Copy link
Member

@rwjblue seems logical to me. Did this bite someone somewhere?

@rwjblue
Copy link
Member Author

rwjblue commented Mar 3, 2021

Not that I know of (though on my system I do not have a node in $PATH so it would have bit me if I were using this addon)! I just noticed while perusing the code.

@RobbieTheWagner
Copy link
Member

@bendemboski I am fine with making this change if you are

bendemboski added a commit that referenced this issue Mar 3, 2021
@bendemboski
Use process.execPath is the test runner
0cb6792 
Use process.execPath instead of 'node' so we use the same Node executable that is running ember-cli, rather than rely on the user's PATH to point to the right (or any) version of Node.

Thanks @rwjblue for pointing this out

Fixes #750
@bendemboski bendemboski mentioned this issue Mar 3, 2021
Merged
RobbieTheWagner pushed a commit that referenced this issue Mar 3, 2021
Use process.execPath is the test runner (#751)
65b43e4 
Use process.execPath instead of 'node' so we use the same Node executable that is running ember-cli, rather than rely on the user's PATH to point to the right (or any) version of Node.

Thanks @rwjblue for pointing this out

Fixes #750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bendemboski bendemboski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use process.execPath is the test runner adopted-ember-addons/ember-electron
3 participants
@rwjblue @bendemboski @RobbieTheWagner