Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 4.8 #1263

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Ember 4.8 #1263

merged 3 commits into from
Oct 24, 2022

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

@RobbieTheWagner
Copy link
Member Author

@bendemboski any idea why tests are failing here?

@bendemboski
Copy link
Member

@rwwagner90 I'd bet it's emberjs/ember-inspector#2188. I had to disable installing Ember inspector in tests in my project because of that bug. The blueprint creates test/index.js, so I think we either need to wait for a fix for that issue to be released in Ember inspector, or figure out how to make the end-to-end tests comment out that code or something after running the blueprint but before launching the Ember tests.

@RobbieTheWagner
Copy link
Member Author

@bendemboski gotcha, I will release the fix

@RobbieTheWagner RobbieTheWagner merged commit 1656b02 into main Oct 24, 2022
@RobbieTheWagner RobbieTheWagner deleted the ember-4.8 branch October 24, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @bendemboski