electron-forge 6 #1279
electron-forge 6 #1279
Conversation
It's finally out of beta!!!
bendemboski
force-pushed
the
forge-6
branch
2 times, most recently
from
4a64fb4 to
475769c
Compare
| let zipMaker = makers.find((m) => m.name === '@electron-forge/maker-zip'); | ||
| delete zipMaker.platforms; | ||
| writeJsonSync(packageJsonPath, packageJson); | ||
| it.only('makes', () => { |
There was a problem hiding this comment.
@bendemboski do we mean to be only running this one test?
The forge template we use in our blueprint needed to be updated because: * The template API changed so instead of just executing code from `initializeTemplate()` we need to return a list of tasks that execute the code * The base template now generates a `forge.config.js` rather than putting the configuration inline in `package.json`
|
@rwwagner90 I actually don't think this is breaking...the only thing that looks to me like it has the potential to be breaking is the forge config...but I'm pretty sure it isn't. Previously you would either:
In either case, forge will still find the config. The only difference is that now with new forge, if you don't have a |
|
@bendemboski Ah, the docs were confusing then. It looked like the changes you made indicated a config file was required instead of configuring in package.json. |
|
Yeah, it's confusing for sure 😆 But the documentation changes are all related to the blueprint/upgrading from 2.x instructions, which don't affect existing 3.x apps. |
No description provided.