Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Prefix all events/callbacks with on #701

Closed
9 tasks done
Tracked by #331
gilest opened this issue Feb 18, 2022 · 0 comments · Fixed by #705
Closed
9 tasks done
Tracked by #331

Proposal: Prefix all events/callbacks with on #701

gilest opened this issue Feb 18, 2022 · 0 comments · Fixed by #705

Comments

@gilest
Copy link
Collaborator

gilest commented Feb 18, 2022 •
edited
Loading

  • FileDropzone
  • selectFile modifier
    • filesSelected -> onFilesSelected
  • FileUpload
    • filesSelected -> onFilesSelected
  • file-queue helper
    • filesSelected -> onFilesSelected
    • fileAdded -> onFileAdded
    • fileRemoved -> onFileRemoved
This was referenced Feb 18, 2022
Merged
Closed
@gilest gilest changed the title Proposal: Prefix all callbacks with on Proposal: Prefix all events/callbacks with on Feb 21, 2022
@gilest gilest mentioned this issue Feb 21, 2022
Merged
gilest added a commit that referenced this issue Feb 21, 2022
@gilest
Prefix all callbacks with on (#705)
4a329e9 
Attempting to bring all callback naming to a consistent format.

Fixes #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefix all callbacks with on adopted-ember-addons/ember-file-upload
1 participant
@gilest