chore: Service cannot be used before helper failing test #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When `fileQueue` service is used _before_ `(fileQueue)` helper, then app fails with:
```
ember.js:626 Uncaught (in promise) Error: Assertion Failed: You attempted to update `_value` on `TrackedStorageImpl`, but it had already been used previously in the same computation. Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.
`_value` was first used:
- While rendering:
-top-level
application
index
(unknown template-only component)
(result of a `unknown` helper)
(result of a `unknown` helper)
(result of a `unknown` helper)
false.files
```
- This PR is just to document the issue described in adopted-ember-addons#1085
MichalBryxi
commented
Sep 25, 2024
| @@ -20,6 +20,31 @@ module('Integration | Helper | file-queue', function (hooks) { | |||
| setupRenderingTest(hooks); | |||
| setupMirage(hooks); | |||
|
|
|||
| test('service can be used before helper', async function (assert) { | |||
There was a problem hiding this comment.
Until some code fixing the addon is pushed, this test will fail. And that is ok as this PR is only intended to show the bug. I don't think I will have time anytime soon to fix the code itself, so very happy if someone can take-over and finish this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileQueueservice is used before(fileQueue)helper, then app fails with:Note that for me to run the test suite locally I had to first apply following patches:
setResolverorsetApplication#1084