FIX - Incomplete use of htmlSafe() on Cell.style #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing large numbers of these warnings: `Binding style attributes may introduce cross-site scripting vulnerabilities ...` on Ember 3.3.2. The empty string being returned when there is no `columnWidth` needed to be wrapped in `htmlSafe()` or changed to `null`. Also I think the `htmlSafe()` call needs to wrap the entire `width: ...` style.
|
I'm getting this issue too. I'm running Ember 3.2.2, super annoying because it clogs up my console XD (1 warning for every cell, since all of my columns have no defined width) |
|
CC: @alexander-alvarez @buschtoens any update on getting this merged in? Thanks for taking a look at it! FWIW - I added this + the removal of the |
|
Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing large numbers of these warnings:
Binding style attributes may introduce cross-site scripting vulnerabilities ...on Ember 3.3.2.The empty string being returned when there is no
columnWidthneeded to be wrapped inhtmlSafe()or changed tonull. Also I think thehtmlSafe()call needs to wrap the entirewidth: ...style.